Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tellable shouldn't gist messages #354

Open
AlexDaniel opened this issue Aug 25, 2019 · 1 comment
Open

tellable shouldn't gist messages #354

AlexDaniel opened this issue Aug 25, 2019 · 1 comment
Labels
tellable Issues related to Tellable bot

Comments

@AlexDaniel
Copy link
Member

See IRC log.

The message was too long so it gisted it, but it didn't mention the user so a message like this can go unnoticed. Moreover, even if the message doesn't fit a little bit, it shouldn't gist it. Maybe in cases like this it should split the message in half, or something like that.

@AlexDaniel AlexDaniel added the tellable Issues related to Tellable bot label Aug 25, 2019
@AlexDaniel AlexDaniel reopened this Jan 28, 2020
@AlexDaniel
Copy link
Member Author

It's much better now but it is still an issue.

<TreyHarris> You could look at https://github.com/weechat/weechat/blob/d2dda92dafcf346d1a158f308e7f8fbfcc313281/src/plugins/irc/irc-message.c#L983 which is how WeeChat decides whether and how to split messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tellable Issues related to Tellable bot
Projects
None yet
Development

No branches or pull requests

1 participant