Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: remove support for ranges as a commit option #346

Open
MasterDuke17 opened this issue Jan 22, 2019 · 1 comment
Open

RFC: remove support for ranges as a commit option #346

MasterDuke17 opened this issue Jan 22, 2019 · 1 comment
Labels
decluttering Removing unneeded features/bloat good first issue Low-hanging fruit (relatively easy issue, good for drive-by contributions) RFC

Comments

@MasterDuke17
Copy link
Collaborator

I don’t think it (e.g., 1218.12..HEAD) has ever been used in the wild so it’s just an extra code path to maintain and test.
@AlexDaniel AlexDaniel added decluttering Removing unneeded features/bloat RFC labels Jan 23, 2019
@AlexDaniel
Copy link
Member

I agree. Personally I did use it a few times (it was something like 2018.10..HEAD when there were not many commits after the release, also I remember doing something like 2018.10~100..2018.10), but nowadays I'd much rather use Whateverable as a library and run it on my own computer (gist). Feel free to remove the feature and the corresponding tests.

@AlexDaniel AlexDaniel added the good first issue Low-hanging fruit (relatively easy issue, good for drive-by contributions) label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decluttering Removing unneeded features/bloat good first issue Low-hanging fruit (relatively easy issue, good for drive-by contributions) RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexDaniel @MasterDuke17