Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] Enhance the mic button color scheme #1930

Closed
4 tasks done
Ajai-Sharan opened this issue Dec 19, 2024 · 9 comments · Fixed by #1951
Closed
4 tasks done

[Style] Enhance the mic button color scheme #1930

Ajai-Sharan opened this issue Dec 19, 2024 · 9 comments · Fixed by #1951
Assignees
Labels
Easy Low effort straightforward task enhancement ✨ New feature or request KWOC KWOC Open Source Program style tweak 🎨 Improve the website style or formatting

Comments

@Ajai-Sharan
Copy link
Contributor

What's the style idea?

We need to improve

Description:
The mic button next to the search bar is looks same in both the dark and light mode. I would be better if we use different color scheme for different mode

Screenshots:
image
image

Checklist

  • I have checked the existing issues.
  • I follow Contributing Guidelines of this project.
  • I am a KWOC'24 contributor.

Code of Conduct

Copy link

Hey @Ajai-Sharan, Welcome to the project CalcDiverse! 🎊
Thanks for opening an issue! 🙌 Please wait for the issue to be assigned. Happy Coding!! ✨

@Ajai-Sharan
Copy link
Contributor Author

@Rakesh9100 I would like to work on this issue. please assign this to me.

@Ajai-Sharan Ajai-Sharan changed the title [Style] <write a small description here [Style] same color used for mic button in both the modes Dec 19, 2024
@Ajai-Sharan Ajai-Sharan changed the title [Style] same color used for mic button in both the modes [Style] Enhance the mic button color scheme Dec 20, 2024
@Rakesh9100 Rakesh9100 added the status: standby ✊ This issue is on hold label Dec 20, 2024
@Atharvverma1234
Copy link
Contributor

Hello Sir, I would like to work on this issue, Please assign it to me. Thank you.

@Rakesh9100
Copy link
Owner

Can you provide the screenshot of how it will look in both the themes @Ajai-Sharan

@Rakesh9100 Rakesh9100 added question 🤔 Further information is requested and removed status: standby ✊ This issue is on hold labels Dec 23, 2024
@Ajai-Sharan
Copy link
Contributor Author

Hello sir @Rakesh9100 ,

Screenshots:

image
image
image
image

These are the screenshots. Please review it.

@Rakesh9100
Copy link
Owner

Okay, go ahead with the 2nd option of both @Ajai-Sharan

@Rakesh9100 Rakesh9100 added KWOC KWOC Open Source Program and removed question 🤔 Further information is requested labels Dec 27, 2024
@Ajai-Sharan
Copy link
Contributor Author

@Rakesh9100 I've designed it so that, without hovering over the button, it will look like the first image for both themes, and while hovering, it will look like the second image for both themes.

When we're not hover (in both the themes)

image
image

When we're hovering (in both the themes)

image
image

Should I implement it this way, or should I make the second image the default instead?

@Rakesh9100
Copy link
Owner

Okay, I got confused, you can go ahead with your implementation @Ajai-Sharan

Copy link

Hello @Ajai-Sharan! Your issue #1930 has been closed. Thank you for your contribution!! 🙌

@Rakesh9100 Rakesh9100 added enhancement ✨ New feature or request Easy Low effort straightforward task style tweak 🎨 Improve the website style or formatting labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Low effort straightforward task enhancement ✨ New feature or request KWOC KWOC Open Source Program style tweak 🎨 Improve the website style or formatting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants