Submitting order crashes sometimes #342
Assignees
Labels
bug
Something isn't working
Comments
|
Doesn't occur anymore |
|
The acceptance criteria for closing this issue will be to honeybadger not reporting this for some days on production. |
lukaszreszke
added a commit
that referenced
this issue
Jul 29, 2024
Current implementation is very happy-path oriented. When order exists, everything is fine. However, when there is no order, then the NoMethodError (as in honeybadger) is thrown. The behaviour is changed now. The 404 page is returned when there is no order for given id. https://app.honeybadger.io/projects/58419/faults/91462781/01J3Y753P7F6F70CYT2ZQE1VND #342
|
I investigated the error message and it seems like it is not possible to reproduce. The reason is the fact that those errors are caused by web-crawlers.
Those web-crawlers try to access non-existing orders. Therefore, the NoMethod error is thrown. I changed the behaviour and the 404 page will be returned instead [4878e71] |
|
The 404 page is ugly though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to our tracker (honeybadger) we get
NoMethodError: undefined methoduid' for nil:NilClass` sometimes.It seems to come from
orders/showaction. On further investigation it comes after we redirect toshowfrom thecreateaction.The
createaction creates 2 commands, which then result in events, which then are handled by read models.It's very likely that after the recent switch to async event handlers, now this not often executes on time.
We'd need to fix this somehow.
The text was updated successfully, but these errors were encountered: