Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing to current plan (e.g. silver => silver) causes template error #159

Open
benmicol opened this issue Sep 14, 2015 · 0 comments
Open

Comments

@benmicol
Copy link

Minor issue, but the case when changing plan to the existing/same plan is not properly routed and causes a missing template error. The simple work around was to add another condition statement in the registrations controller so that when the "plan == current_user.plan" a flash message of something like.... "Must choose a different plan...." appears and then renders the ":edit" page again. As it stands, the registration controller's "change plan" method only accounts for cases that fall under the "unless plan == current_user.plan" condition. I understand that this may be outside of the scope of the project and it is a trivial "fit and finish" concern, but I thought I would mention it since it is a relatively simple fix, depending on the best practice for implementation, of which my workaround is probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant