-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
77 pressure losses and distribution #102
base: main
Are you sure you want to change the base?
Conversation
…ion reference files. Please pull the new files before push again. Plottet Results /77_pressureLossesAndDistribution/charts/
…/RWTH-EBC/BESMod into 77_pressureLossesAndDistribution
…ion reference files. Please pull the new files before push again. Plottet Results /77_pressureLossesAndDistribution/charts/
…ion reference files. Please pull the new files before push again. Plottet Results /77_pressureLossesAndDistribution/charts/
…/RWTH-EBC/BESMod into 77_pressureLossesAndDistribution
…ion reference files. Please pull the new files before push again. Plottet Results /77_pressureLossesAndDistribution/charts/
…/RWTH-EBC/BESMod into 77_pressureLossesAndDistribution
Thank you for making a Pull Request to BESMod! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
…/RWTH-EBC/BESMod into 77_pressureLossesAndDistribution
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /77_pressureLossesAndDistribution/charts/
…/RWTH-EBC/BESMod into 77_pressureLossesAndDistribution
…extra storage loss term
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
3 similar comments
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/77_pressureLossesAndDistribution/charts |
This PR closes #77 and closes #25.
The changes are not backwards compatible, as the movers are moved to the distribution systems to address #25.
Conversion scripts and a migration guide will be posted.