Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Refactor Time Inputs & Hold Times #472

Open
bonedaddy opened this issue Apr 8, 2020 · 0 comments
Open

Refactor Time Inputs & Hold Times #472

bonedaddy opened this issue Apr 8, 2020 · 0 comments
Labels
v3 tracks issues related to v3 of temoral
Milestone

Comments

@bonedaddy
Copy link
Contributor

As noted by @xiegeo in #467 (comment), there is room for refinement when it comes to how we handle hold times, and validation of them.

Day Long Increments Of Hold Time

Instead of using monthly hold times, use increments of 1 day for the pin duration.

Use time.* Types for Validation

At the moment we have a mixed bag of validating hold times, consisting of either time.* types or holdTimeInMonths int types. Instead we should have the user supply the number of days they want to pin for, and then immediately convert this to a time.Time type using time.Now().AddDate(0, 0, holdTimeInDays). We then pass this time.Time object around for manipulation, validation, etc..

@bonedaddy bonedaddy added the v3 tracks issues related to v3 of temoral label Apr 8, 2020
@bonedaddy bonedaddy added this to the v3 milestone Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v3 tracks issues related to v3 of temoral
Projects
None yet
Development

No branches or pull requests

1 participant