Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in some scripts with usage of "set" command #22

Closed
jscatena88 opened this issue Apr 1, 2021 · 5 comments
Closed

Issue in some scripts with usage of "set" command #22

jscatena88 opened this issue Apr 1, 2021 · 5 comments

Comments

@jscatena88
Copy link

I was receiving an error message in the GUI trying to run the "Migration" step, "set: Variable name must begin with a letter". Poking round it seems that line 169 in magic_db.sh has the issue. Specifically changing
set techfile ${techdir}/${techfile}
to
set techfile=${techdir}/${techfile}
fixed the issue. I believe there is a similar issue in magic_drc.sh line 150

@jscatena88
Copy link
Author

also in magic_gds.sh

seems to stem from the 2/22 commit "Modified the way that the magic scripts and the manager GUI handle "

@K0rrid0r
Copy link

K0rrid0r commented Apr 3, 2021

image

I'm having the same problem.

I changed:
magic_db.sh
magic_gds.sh
magic_drc.sh

to:
set techfile=${techdir}/${techfile}

but it didn't move past Migration
Any other suggestion?

I also found the same thing in magic_views.sh

image

@ju-sh
Copy link

ju-sh commented Apr 11, 2021

@jscatena88 Thanks for telling us about this modification. Was able to get past migration with those changes.

Now stuck at LVS just like @K0rrid0r mentions at #23 .

@svenn71
Copy link

svenn71 commented Aug 12, 2021

I attach a patch vs main with the places I have found so far

diff --git a/scripts/magic_db.sh b/scripts/magic_db.sh
index 7edda7e..5f6624c 100755
--- a/scripts/magic_db.sh
+++ b/scripts/magic_db.sh
@@ -166,7 +166,7 @@ set subv=`echo $version | cut -d. -f3`
 
 if ( !(-r $techfile)) then
    if (`echo $techfile | cut -c1` != "/") then
-      set techfile ${techdir}/${techfile}
+      set techfile=${techdir}/${techfile}
    endif
 endif
 if (-r $techfile) then
diff --git a/scripts/magic_drc.sh b/scripts/magic_drc.sh
index 8f9b73e..0f98b89 100755
--- a/scripts/magic_drc.sh
+++ b/scripts/magic_drc.sh
@@ -147,7 +147,7 @@ endif
 
 if ( !(-r $techfile)) then
    if (`echo $techfile | cut -c1` != "/") then
-      set techfile ${techdir}/${techfile}
+      set techfile=${techdir}/${techfile}
    endif
 endif
 if (-r $techfile) then
diff --git a/scripts/magic_gds.sh b/scripts/magic_gds.sh
index 2bf7abe..6b067f2 100755
--- a/scripts/magic_gds.sh
+++ b/scripts/magic_gds.sh
@@ -119,7 +119,7 @@ set subv=`echo $version | cut -d. -f3`
 
 if ( !(-r $techfile)) then
    if (`echo $techfile | cut -c1` != "/") then
-      set techfile ${techdir}/${techfile}
+      set techfile=${techdir}/${techfile}
    endif
 endif
 if (-r $techfile) then
diff --git a/scripts/magic_view.sh b/scripts/magic_view.sh
index 8671f4b..3b8868b 100755
--- a/scripts/magic_view.sh
+++ b/scripts/magic_view.sh
@@ -199,7 +199,7 @@ set dispfile="${layoutdir}/load_${rootname}.tcl"
 # absolute path.
 if ( !(-r $techfile)) then
    if (`echo $techfile | cut -c1` != "/") then
-      set techfile ${techdir}/${techfile}
+      set techfile=${techdir}/${techfile}
    endif
 endif



@jscatena88
Copy link
Author

This issue appears to be fixed by this commit: a2d468e

Closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants