Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare by Raw value #55

Open
mdca opened this issue Mar 9, 2022 · 4 comments
Open

Compare by Raw value #55

mdca opened this issue Mar 9, 2022 · 4 comments

Comments

@mdca
Copy link

mdca commented Mar 9, 2022

I am using JetEngine's Query Builder and I tried adding a condition to show/hide section based on the number of query results however it does not work properly.

This is the debug content:
DynamicTag-Tag:jet-query-count
DynamicTag-Key:
DynamicTag-Value:0
DynamicTag-Value-Raw:0
Check-Value:1
Check-Value2:
Condition-Type:default
Condition:Hide if less
Condition met:no

It appears DynamicConditions is comparing the Check-Value to DynamicTag-Value. Is there a way to force the condition to be checked against DynamicTag-Value-Raw instead using filters or changing some plugin setting I seem no to see anywhere?

@qwik3r
Copy link

qwik3r commented Mar 16, 2022

I don't think the author of this plugin exists anymore. They answer nothing on the git it appears or in Wordpress's forum. I feel like this is an abandoned and now unsupported and thus vulnerable plugin. I'll be seeking something else to use.

@crazypsycho
Copy link
Member

The author still exists. But we have other projects at the moment and can currently only offer support for bugs.
This question does not refer to a bug either.
The plugin always compares the value of the DynamicTag with the values you enter (check value).

@mdca
Copy link
Author

mdca commented Mar 17, 2022

@crazypsycho actually it is a bug, as you can see in the opening post. Dynamic Tag is 0, Check Val is 1 and condition is hide if less and according to the plugin the condition is not met, which is wrong.

@crazypsycho
Copy link
Member

Maybe the dynamic-tag is not really simply 0. It could be something like <span class="something">0</span>
But with new version 1.7.0 you can use integer as compare-type. So it will convert check-value and tag to an integer and it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants