Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OLXBridge] fix title and shiping info retrieval #4346

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[OLXBridge] fix title and shiping info retrieval #4346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions bridges/OLXBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,20 +103,15 @@ public function collectData()
continue;
}

$shippingOffered = $post->find('.css-1c0ed4l svg', 0)->outertext ?? false;
if ($this->getInput('shippingOfferedOnly') && !$shippingOffered) {
continue;
}

$negotiable = $post->find('p[data-testid="ad-price"] span.css-e2218f', 0)->plaintext ?? false;
if ($negotiable) {
$price = trim(str_replace($negotiable, '', $price));
$negotiable = '(' . $negotiable . ')';
}

if ($post->find('h6', 0)->plaintext != '') {
if ($post->find('h4', 0)->plaintext != '') {
$item['uri'] = $post->find('a', 0)->href;
$item['title'] = $post->find('h6', 0)->plaintext;
$item['title'] = $post->find('h4', 0)->plaintext;
}

# ignore the date component, as it is too convoluted — use the deep-crawled one; see below
Expand All @@ -128,6 +123,12 @@ public function collectData()
# Given that, do deep-crawl *all* the results, which allows to aso obtain the ID, the simplified location
# and date strings, as well as the detailed description.
$articleHTMLContent = getSimpleHTMLDOMCached($item['uri']);
$articleHTMLContent = defaultLinkTo($articleHTMLContent, $this->getHostname());

$shippingOffered = $articleHTMLContent->find('img[alt="Safety Badge"]', 0)->src ?? false;
if ($this->getInput('shippingOfferedOnly') && !$shippingOffered) {
continue;
}

# Extract a clean ID without resorting to the convoluted CSS class or sibling selectors. Should be always present.
$refreshLink = $articleHTMLContent->find('a[data-testid=refresh-link]', 0)->href ?? false;
Expand Down Expand Up @@ -195,7 +196,7 @@ public function collectData()
<tr>
<td>
<p>$location</p>
<p><span style="font-weight:bold">$price</span> $negotiable <span>$shippingOffered</span></p>
<p><span style="font-weight:bold">$price</span> $negotiable <span><img src="$shippingOffered"</img></span></p>
</td>
</tr>
<tr>
Expand Down