Implementation of Module singularities #1685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow it to be stored properly on early loading stage.
…, PipeFluidSatellite, PipeFluidSupplierMk2, PipeItemsFluidSupplier. Change conditions stuff in PipeItemsSatelliteLogistics (Commit for: RS485#1679)
…struction on SimpleStackInventory (Commit for: RS485#1679)
…operty not saved correctly
…temDestinationLogistics, PipeItemsSystemEntranceLogistics, some small enhancement
KorewaLidesu
changed the title
This reverts commit 4d3c4e3.
…LogisticsMk2, add other features that I cant type all out
KorewaLidesu
changed the title
|
The PR is ready to review! |
# Conflicts: # common/logisticspipes/gui/GuiFirewall.java # common/logisticspipes/gui/orderer/GuiRequestTable.java # common/logisticspipes/pipes/PipeItemsFirewall.java # common/logisticspipes/pipes/PipeItemsInvSysConnector.java # common/logisticspipes/pipes/PipeItemsSystemDestinationLogistics.java # common/logisticspipes/pipes/PipeLogisticsChassis.java
|
Merged with upstream! |
bziemons
reviewed
Apr 15, 2023
src/api/kotlin/network/rs485/logisticspipes/property/Property.kt
Outdated
Show resolved
Hide resolved
|
Should be good to go then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing procedure has done. All test successed.
Need players to test if there is other issue.
PR: Implementing Modules to replace
readFromNBT&writeToNBTResolve #1679 (comment)
Thing has done: