Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Issue loading top kernels. Check pmc_kernel_top.csv' when using --no-roof on MI200 #313

Closed
skyreflectedinmirrors opened this issue Mar 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@skyreflectedinmirrors
Copy link
Contributor

Describe the bug

omniperf profile -n test --no-roof -- ./whatever
omniperf analyze -p workloads/test/MI200
$ omniperf analyze -p workloads/stream/MI200/

  ___                  _                  __ 
 / _ \ _ __ ___  _ __ (_)_ __   ___ _ __ / _|
| | | | '_ ` _ \| '_ \| | '_ \ / _ \ '__| |_ 
| |_| | | | | | | | | | | |_) |  __/ |  |  _|
 \___/|_| |_| |_|_| |_|_| .__/ \___|_|  |_|  
                        |_|                  

Analysis mode = cli
[analysis] deriving Omniperf metrics...
Issue loading top kernels. Check pmc_kernel_top.csv

Digging a bit, it appears we're emitting this from here:

https://github.com/AMDResearch/omniperf/blob/bfef4200993f0110f45753f8f9c4a7810b83c6ff/src/utils/parser.py#L926

when the roofline csv doesn't exist. At the very least we shouldn't always say it's top_kernels.csv or w/e, and say "no roofline detected". Arguably, this shouldn't be a warning at all as --no-roof is a valid use-case?

@skyreflectedinmirrors skyreflectedinmirrors added the bug Something isn't working label Mar 13, 2024
coleramos425 added a commit that referenced this issue Mar 22, 2024
coleramos425 added a commit that referenced this issue Mar 29, 2024
coleramos425 added a commit that referenced this issue Apr 1, 2024
coleramos425 added a commit that referenced this issue Apr 1, 2024
coleramos425 added a commit that referenced this issue Apr 1, 2024
@ppanchad-amd
Copy link

@skyreflectedinmirrors Issue is fixed. Closing ticket. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants