You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ConnectionSettings::close_after_match has confused a few people using the lower level interfaces since the connection is not actually closed when the match ends, but rather, when a match is stopped with a StopMatch message or a new match begins with a StartMatch message. I propose renaming it to close_between_matches.
The text was updated successfully, but these errors were encountered:
I think its pretty hard to define the behavior of this field with a short name. close_between_matches still implies that the bot will get closed after a match. The best we could do IMO is replace/append this comment with something like /// RLBot doesn't actually know when a match ends. Therefor, your bot/script will only be closed once a StopMatch or StartMatch packet is sent.
Yeah, that comment would be a great addition to remove all confusion. But I still think close_between_matches is slightly better since it does not have immediacy to it.
The
ConnectionSettings::close_after_match
has confused a few people using the lower level interfaces since the connection is not actually closed when the match ends, but rather, when a match is stopped with aStopMatch
message or a new match begins with aStartMatch
message. I propose renaming it toclose_between_matches
.The text was updated successfully, but these errors were encountered: