Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String values in the toml file have inconsistent casing #50

Open
NicEastvillage opened this issue Oct 6, 2024 · 1 comment
Open

String values in the toml file have inconsistent casing #50

NicEastvillage opened this issue Oct 6, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@NicEastvillage
Copy link
Contributor

NicEastvillage commented Oct 6, 2024

This always bothered me in v4, and it is here again in v5 (at least it is only the values and not also the fields this time)

The string values in the toml files have an inconsistent casing. Consider the following snippet from VirxEC/python-interface/test/rlbot.toml:

[rlbot]
launcher = "steam"
auto_start_bots = true

[match]
game_mode = "Soccer"
game_map_upk = "Stadium_P"
existing_match_behavior = "Restart"
enable_rendering = true

[mutators]
match_length = "Twenty_Minutes"
ball_max_speed = "Fast"
boost_strength = "OneAndAHalf"
respawn_time = "One_Second"

[[cars]]
team = 0
type = "psyonix"
skill = "pro"

The strings have a mix of PascalCase, lower case, and Snakey_Pascal_Case. This is ugly and makes it difficult to write toml files by hand.

Let's make the string value casing consistent. I vote for PascalCase or UPPER_SNAKE_CASE. Using lower snake_case for fields and values seems wrong imo.

Of course, strings like bot names and paths should not adhere to this casing convention, but all the framework constants should.

@NicEastvillage NicEastvillage added the enhancement New feature or request label Oct 6, 2024
@VirxEC
Copy link
Collaborator

VirxEC commented Oct 6, 2024

All strings are lower/upper case insensitive. Most are just the names of the enums in the flatbuffer spec so the name should be changed there

@VirxEC VirxEC added the good first issue Good for newcomers label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants