-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider a database instead of json #19
Comments
Use postgresql & host it on Heroku - that should be just fine |
I get the impression that it would take a long time for it to grow to the point of being unwieldy. But future proofing is generally a good idea. Might be a nice easy project to tackle for a fledgling developer. |
While I agree that a relational database would be better suited for this data, a relational database can significantly improve the consistancy of the data. However, I am not sure if it would be worth the effort because it does make the entire setup much more complicated. If anything we could write some automated tests to quickly validate the json when reviewing PRs. |
Yeah, and the current setup has some great properties:
|
Definitely. Those properties should not be taken for granted. It's not like I think we need to switch any time soon. |
The json file is growing quickly, but json is not a great long term. We should consider moving to a proper database at some point. This ofc comes with multiple complications - like where should it be hosted. For now I am just opening this issue for potential discussion.
The text was updated successfully, but these errors were encountered: