Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata as list rather than tibble? #12

Open
leeper opened this issue Jan 2, 2017 · 2 comments
Open

Metadata as list rather than tibble? #12

leeper opened this issue Jan 2, 2017 · 2 comments
Labels

Comments

@leeper
Copy link
Member

leeper commented Jan 2, 2017

What do you think of making the metadata element of a the "po" object a list rather than a tibble? This will make it easier to assign values when generating a translation from a pot file.

@leeper leeper added the question label Jan 2, 2017
@richierocks
Copy link
Collaborator

I actually started with metadata as a list. I changed it because I was trying to stick to tidyverse principles, and because tibbles are easier to read (with eyeballs). You are right that the assignment syntax is much clumsier than with lists.

I guess our options are

  • keep using tibbles and write wrapper functions to make it easier to assign/manipulate the metadata.
  • switch back to lists and write a print function to make the output easier to read.

I don't have a strong preference either way; let me know which you prefer.

@leeper
Copy link
Member Author

leeper commented Jan 2, 2017

Let's sit on it for now. I've got msgtools working with the existing format so it's not urgent. If it becomes annoying later on, we can change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants