You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the function looks for Bash remediations only - this may incorrectly waive failing Ansible results that do have a valid Ansible remediation, but no Bash remediation scripts.
Also, the existing Bash-based logic is fairly hacky and manual. Try parsing the datastream XML instead.
The text was updated successfully, but these errors were encountered:
For searching Ansible remediation, we could utilize similarly as for Bash # oscap xccdf generate --profile '(all)' fix --fix-type ansible and in output search for rule id. Ansible remediation has its rule id in tags:.
However, this approach will not work for IB as --fix-type blueprint creates you blueprint without any indication what rule is covered by what. For that, XML parsing is needed.
Significant help towards this is e1100f0 done via #155 .
This allows us to directly query bash/ansible/etc. remediations in the datastream XML.
Now we'd need to figure out how has_no_remediation() should work and how / if to parametrize it based on the remediation type being tested (/hardening/oscap vs /hardening/ansible vs ...).
The main reason we need to do this is to fix some false positives on non-Bash remediation technologies.
For example - kickstart / OAA / image-builder hardening should remediate some things that oscap alone cannot, like disk partitions (ie. by including them in an osbuild blueprint), and scans for those hardening types should not auto-waive failures in those rules. Doing so can lead to hiding bugs.
Currently, the function looks for Bash remediations only - this may incorrectly waive failing Ansible results that do have a valid Ansible remediation, but no Bash remediation scripts.
Also, the existing Bash-based logic is fairly hacky and manual. Try parsing the datastream XML instead.
The text was updated successfully, but these errors were encountered: