Spurious "libGatingSet.pb library not found" warning with RProtoBufLib 2.3.2

[hpages]

See: RGLab/cytolib#37 (comment)

Another problem with the current code is that, in the case that the libGatingSet.pb library is actually missing, gsLibPath() will return an empty string so testing with if (!file.exists(gs)) in the .onLoad() hook is bogus. Should rather be done with something like if (gs == ""). Or, a better solution would be to use file.path() instead of system.file() in the gsLibPath() function, so the relative path to the library is always returned, even if the file doesn't exist. Then you can test with if (system.file(gs, "RProtoBufLib") == "") in the .onLoad() hook. Another advantage of doing this is that the warning message would actually display the path (right now it doesn't because gs is the empty string).

The code for detecting the presence of the libprotobuf library (pbLibPath()) has the same problems.

[mikejiang]

Thanks for the tips, @hpages . For now, I just fix the warnings. will circle back to clean it up when I have time later.