Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retip: better input type check/conversion of retip_apply #88

Open
ljocha opened this issue Feb 17, 2021 · 0 comments
Open

retip: better input type check/conversion of retip_apply #88

ljocha opened this issue Feb 17, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ljocha
Copy link
Contributor

ljocha commented Feb 17, 2021

retip_apply accepts 'h5' and 'tabular' input types. If it is given an input of 'tabular' type literally, it runs spell.R, otherwise spell_h5.R. This strategy breaks with subtypes of tabular, which revert to h5 not being h5. Technically, the non-h5 version accepts tsv only.

Consequently, the tool must be given either h5, or a tsv explicitely retyped to tabular, otherwise it fails.

I'm not sure whether we can benefit from some automatic type conversion, so I'm leaving the right solution to experts. But it should be made more robust.

@hechth hechth changed the title better input type check/conversion of retip_apply retip: better input type check/conversion of retip_apply Jun 9, 2021
@hechth hechth added the enhancement New feature or request label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants