Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchms networking Identifier key is not an optional variable #445

Open
chufz opened this issue Nov 23, 2023 · 1 comment
Open

matchms networking Identifier key is not an optional variable #445

chufz opened this issue Nov 23, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@chufz
Copy link

chufz commented Nov 23, 2023

An error occurs when matchms networking is used without any entry for the Identifier key. However, it is marked as optional in the GUI.

Additionally, the user needs to know that what metadata might be in the metadata of the mgf /msp with capital letters will be transformed to a variable name with lower cases in the json file with the similarity matrix.

Following error occurs:

  File "/gpfs1/data/galaxy_server/galaxy/shed_tools/toolshed.g2.bx.psu.edu/repos/recetox/matchms_networking/3289420aaaca/matchms_networking/matchms_networking_wrapper.py", line 41, in <module>
    main(argv=sys.argv[1:])
  File "/gpfs1/data/galaxy_server/galaxy/shed_tools/toolshed.g2.bx.psu.edu/repos/recetox/matchms_networking/3289420aaaca/matchms_networking/matchms_networking_wrapper.py", line 34, in main
    network.create_network(scores, score_name)
  File "/usr/local/lib/python3.11/site-packages/matchms/networking/SimilarityNetwork.py", line 116, in create_network
    msnet.add_nodes_from(unique_ids)
  File "/usr/local/lib/python3.11/site-packages/networkx/classes/graph.py", line 635, in add_nodes_from
    raise ValueError("None cannot be a node")
ValueError: None cannot be a node ```
@hechth hechth added bug Something isn't working enhancement New feature or request labels Feb 22, 2024
@hechth
Copy link
Member

hechth commented Aug 5, 2024

@chufz seems like this is already implemented - can you double check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants