Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solving the test.pypi release issue #96 #97

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

mohammadamint
Copy link
Collaborator

@mohammadamint mohammadamint commented Nov 6, 2023

Closes #96

updating the secrets for API Token for the automatic test release of software after Pushes and PRs to developemnt and main

@mohammadamint mohammadamint requested a review from FLomb November 6, 2023 18:32
@mohammadamint
Copy link
Collaborator Author

@FLomb the action is failing due to some syntax error in README.rst:

ERROR long_description has syntax errors in markup and would not be
rendered on PyPI.
line 65: Warning: Title underline too short.

Is this solved in your new PR?

@FLomb
Copy link
Contributor

FLomb commented Nov 7, 2023

@FLomb the action is failing due to some syntax error in README.rst:

ERROR long_description has syntax errors in markup and would not be rendered on PyPI. line 65: Warning: Title underline too short.

Is this solved in your new PR?

Hi, I have updated PR #95 to fix the mismatch between the title length and the underlying "~" string. Is that the issue here? However, I haven't yet merged PR #95 due to some other failing tests.

@mohammadamint
Copy link
Collaborator Author

@FLomb the action is failing due to some syntax error in README.rst:
ERROR long_description has syntax errors in markup and would not be rendered on PyPI. line 65: Warning: Title underline too short.
Is this solved in your new PR?

Hi, I have updated PR #95 to fix the mismatch between the title length and the underlying "~" string. Is that the issue here? However, I haven't yet merged PR #95 due to some other failing tests.

The issue is coming from the README.rst. I can fix that, in this PR, but I will wait for the other PRs on docs to be merged, then will the full check

@mohammadamint mohammadamint mentioned this pull request Nov 7, 2023
@FLomb
Copy link
Contributor

FLomb commented Nov 7, 2023

@FLomb the action is failing due to some syntax error in README.rst:
ERROR long_description has syntax errors in markup and would not be rendered on PyPI. line 65: Warning: Title underline too short.
Is this solved in your new PR?

Hi, I have updated PR #95 to fix the mismatch between the title length and the underlying "~" string. Is that the issue here? However, I haven't yet merged PR #95 due to some other failing tests.

The issue is coming from the README.rst. I can fix that, in this PR, but I will wait for the other PRs on docs to be merged, then will the full check

I have fixed the issue with line 65 of the README.rst in my recent PR #95. If you now update this to the latest development branch, you should have no further issues.

@mohammadamint
Copy link
Collaborator Author

@FLomb this PR is finalized from my side and believe is ready to be merged

@Bachibouzouk Bachibouzouk linked an issue Nov 7, 2023 that may be closed by this pull request
@Bachibouzouk
Copy link
Collaborator

@mohammadamint if you write fix #<issue number> (or closes) in the PR first post it links to the issue and closes it automatically upon merge, whereas writing the issue in the title lead to confusion between issue number and the PR numer itself ;)

Copy link
Collaborator

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful, the listed commit to be merged have apparently already been merged in PR #95, except they bear different commit numbers. I am not exactly sure how this did happen but 4 of the 6 commits are already into development and should not been merged again under other commit numbers. I tried locally to rebase test-pypy-action onto development and it is done frictionless, only the two commits remain on top of development. I can force push this branch if you wish

updating the secrets for API Token for the automatic test release of
software after Pushes and PRs to developemnt and main
using kebab-case for skip-exisiting and repository-url
@mohammadamint
Copy link
Collaborator Author

Be careful, the listed commit to be merged have apparently already been merged in PR #95, except they bear different commit numbers. I am not exactly sure how this did happen but 4 of the 6 commits are already into development and should not been merged again under other commit numbers. I tried locally to rebase test-pypy-action onto development and it is done frictionless, only the two commits remain on top of development. I can force push this branch if you wish

Yes please.
I think I am not doing the rebase properly, as the same happened last time. I would ask you later to help me understand how to do it correctly 😊

Copy link
Contributor

@FLomb FLomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@FLomb FLomb merged commit 38accd4 into development Nov 8, 2023
2 checks passed
@FLomb FLomb deleted the test-pypy-action branch November 8, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solving the test.pypi release issue
3 participants