Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed not having effect when indicating dates in UseCase #156

Open
Sir-M opened this issue Jul 10, 2024 · 2 comments
Open

Seed not having effect when indicating dates in UseCase #156

Sir-M opened this issue Jul 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Sir-M
Copy link

Sir-M commented Jul 10, 2024

Hello everyone,
While testing RAMP, I found that random_seed parameter of the UseCase does not work when indicating date_start and date_end.

When running initialize(force=True) afterwards, this issue is resolved. But given the cli output when initializing without forcing (The usecase '' is already initialized. If you want to force the reinitialization, use argument force=True), I would expect random_seed to be taken into consideration even without reinitialization.

This issue can be replicated with the random_seed.ipynb provided in the /docs/notebooks. Changes only include adding start and end date to the UseCase uc_2 and uc_3, as follows:
uc_2 = UseCase(users=deepcopy(User_list), random_seed=1, date_start="2020-01-01", date_end="2020-01-01")

image

I'd be happy to support resolving this issue. Do you have recurring development calls?

@Sir-M Sir-M added the bug Something isn't working label Jul 10, 2024
@Bachibouzouk
Copy link
Collaborator

Hello @Sir-M

Thanks for testing RAMP and sharing the bug with us and for your detailed bug report. I could reproduce the bug and I proposed a fix in #157 :)

Would you mind confirming that it also works for you?

@Sir-M
Copy link
Author

Sir-M commented Jul 10, 2024

Yes, the fix works for me 👍
Thanks for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants