Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full bugs extracted #1

Closed
R00tedbrain opened this issue Oct 29, 2024 · 0 comments · Fixed by #2
Closed

Full bugs extracted #1

R00tedbrain opened this issue Oct 29, 2024 · 0 comments · Fixed by #2

Comments

@R00tedbrain
Copy link
Owner

Issue muke1908#388: build(deps-dev): bump http-proxy-middleware from 2.0.6 to 2.0.7 in /client
Bumps http-proxy-middleware from 2.0.6 to 2.0.7.

Release notes

Sourced from http-proxy-middleware's releases.

v2.0.7

Full Changelog: chimurai/http-proxy-middleware@v2.0.6...v2.0.7

v2.0.7-beta.1

Full Changelog: chimurai/http-proxy-middleware@v2.0.7-beta.0...v2.0.7-beta.1

v2.0.7-beta.0

Full Changelog: chimurai/http-proxy-middleware@v2.0.6...v2.0.7-beta.0

Changelog

Sourced from http-proxy-middleware's changelog.

v2.0.7

  • ci(github actions): add publish.yml
  • fix(filter): handle errors
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Issue muke1908#378: AES key should be encrypted before exchange
https://github.com/muke1908/chat-e2ee/blob/905c8c0f1048d9a78509a7bcfed75bda361d8c54/service/src/sdk.ts#L148

Right now AES encryption key is sent to server for exchange which is a vulnerability. It should be send via end-to-end encrypted channel.

Issue muke1908#352: Related to delete link feature
Problem:

  1. When one person deletes the link and other doesn't know about it and tries to send message, it shows failed to send message try again. This doesn't give a clear message to the user that link is deleted. It can also convey that there might be other issue like network problem or such.
  2. If I am opening the same link from the tab that I have deleted, it says waiting for alice to join whereas other person is already joined.

Solution:

  1. When one user deletes the link, the chat from the other person should also be deleted giving a message this link is destroyed
  2. Instead of sending the message "failed to send message try again", should give some specific message like link is deleted.

image

Issue muke1908#346: Creation of Minimalistic UI Client-v2
Modification of the front end apparence of the LinkDisplay and ChatLink Components. Before Continuing with the text messaging section would like to have this part approved first.

Issue muke1908#320: User should be able to send file
Extend the method await chatInstance.encrypt('some message').send(); and give user an option to send files.

https://github.com/muke1908/chat-e2ee/blob/master/service/README.md#3-send-message

Issue muke1908#319: Write UT for ChatE2EE class
ChatE2EE class should be covered by Unit Test

https://github.com/muke1908/chat-e2ee/blob/master/service/src/sdk.ts

Issue muke1908#311: Write UT for SocketInstance in chat-e2ee/service module
Mock 'socket.io-client' library and write unit test.

https://github.com/muke1908/chat-e2ee/blob/master/service/src/socket/socket.ts

Issue muke1908#309: User should be able to send image.
Convert image to base64 and send it by calling await chatInstance.encrypt('some message').send();
https://github.com/muke1908/chat-e2ee/blob/master/service/README.md#3-send-message

Issue muke1908#297: Create a minimalistic UI client using the chat-e2ee/service SDK
Use the SDK @chat-e2ee/service and build a minimalistic UI
https://github.com/muke1908/chat-e2ee/tree/master/service

Scope of this task:

  • Create a separate folder for the client.
  • Create the project (typescript + any UI framework)
  • Install the SDK and initialize it.

Issue muke1908#289: Create a JS playground with @chat-e2ee/service package
Create a fiddle using @chat-e2ee/service package to demonstrate basic functionalities.
use @chat-e2ee/[email protected]

https://github.com/muke1908/chat-e2ee

R00tedbrain added a commit that referenced this issue Nov 5, 2024
Fixes #1


Encrypt the AES key using cryptoUtils.encryptMessage in getRawAesKeyToExport method

Update the comment to reflect that the AES key is now encrypted before transmission


Add item

Encrypt the AES key using cryptoUtils.encryptMessage before sending it to the server in setChannel method

Update the setChannel method to send the encrypted AES key to the server using sharePublicKey

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/R00tedbrain/chat-e2eeBWT/issues/1?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant