From 70739bc43eefcc161aa80d51eaf6809c741caa36 Mon Sep 17 00:00:00 2001
From: database64128 <free122448@hotmail.com>
Date: Thu, 16 Sep 2021 20:55:43 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=AE=20Drop=20TCP=20timeout=20and=20unn?=
 =?UTF-8?q?ecessary=20SetKeepAlive=20(#29)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

I checked Go's source code. Both the TCP listener and dialer sets a 15s keepalive by default. So it's unnecessary to set it in mmp-go. And since we already have TCP keepalive, the timeout is totally unnecessary, and it breaks long connections even if the connection is actively transmitting data.
---
 dispatcher/tcp/tcp.go | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/dispatcher/tcp/tcp.go b/dispatcher/tcp/tcp.go
index 339ebf1..bc89340 100644
--- a/dispatcher/tcp/tcp.go
+++ b/dispatcher/tcp/tcp.go
@@ -3,21 +3,21 @@ package tcp
 import (
 	"errors"
 	"fmt"
-	"github.com/Qv2ray/mmp-go/cipher"
-	"github.com/Qv2ray/mmp-go/config"
-	"github.com/Qv2ray/mmp-go/dispatcher"
-	"github.com/Qv2ray/mmp-go/infra/pool"
 	"io"
 	"log"
 	"net"
 	"sync"
 	"time"
+
+	"github.com/Qv2ray/mmp-go/cipher"
+	"github.com/Qv2ray/mmp-go/config"
+	"github.com/Qv2ray/mmp-go/dispatcher"
+	"github.com/Qv2ray/mmp-go/infra/pool"
 )
 
 //[salt][encrypted payload length][length tag][encrypted payload][payload tag]
 const (
-	DefaultTimeout = 7440 * time.Second
-	BasicLen       = 32 + 2 + 16
+	BasicLen = 32 + 2 + 16
 )
 
 func init() {
@@ -79,7 +79,6 @@ func (d *TCP) handleConn(conn net.Conn) error {
 		userContext *config.UserContext
 	)
 	defer conn.Close()
-	_ = conn.(*net.TCPConn).SetKeepAlive(true)
 
 	var data = pool.Get(BasicLen)
 	defer pool.Put(data)
@@ -110,9 +109,7 @@ func (d *TCP) handleConn(conn net.Conn) error {
 	if err != nil {
 		return fmt.Errorf("[tcp] %s <-> %s <-x-> %s handleConn dial error: %w", conn.RemoteAddr(), conn.LocalAddr(), server.Target, err)
 	}
-	_ = rc.(*net.TCPConn).SetKeepAlive(true)
 
-	_ = rc.SetDeadline(time.Now().Add(DefaultTimeout))
 	_, err = rc.Write(data[:n])
 	if err != nil {
 		return fmt.Errorf("[tcp] %s <-> %s <-x-> %s handleConn write error: %w", conn.RemoteAddr(), conn.LocalAddr(), server.Target, err)