Add "open in disposable yes/no" action to clicking on URLs in Global Config

[marmarta]

Qubes OS release (if applicable)

r4.2

Brief summary

When clicking on links to docs in Global Config, add a question with "open in disposable: yes/no/always open in disposable".
relevant discussion: QubesOS/qubes-desktop-linux-manager#150

[marmarek]

For the "always" option, there needs to be a way to revoke the answer too.

…

-- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab

[alimirjamali]

What about having a dialog with two radio buttons with these actions:

┌───────────────────────────────────────────────────────┐
│ Url:                                                  │
│ ┌───────────────────────────────────────────────────┐ │
│ │ http://www.qubes-os.org/...                       │ │
│ └───────────────────────────────────────────────────┘ │
│ ┌───┐                                                 │
│ │ ✓ │ Save as default action                          │
│ └───┘                                                 │
│ ┌──────────────────┐ ┌──────────────────┐ ┌─────────┐ │
│ │Open in Disposable│ │Copy to Clibboard │ │ Cancel  │ │
│ └──────────────────┘ └──────────────────┘ └─────────┘ │
└───────────────────────────────────────────────────────┘

And using a dom0 feature to store the default action global-config-help-action = disposable, clipboard, ask.

And the option to be configurable in URL Handling tab?

[alimirjamali]

I am considering adding another option to the above dialog. It would be Open via anon-whonix. After this is done, most of it could be reused to make an independent utility to associate HTTP/HTTPS urls of dom0 with it (like a virtual browser). So people could open XFCE and other dom0 program's online helps with it. I believe there is an open issue about it (user asking for a way to open XFCE online helps).

[marmarta]

So, I really like the window idea (and anon-whonix one), with two caveats/ideas:

• when adding this to url handling section, maybe we can also add there which dispvm template to use? Or keep using default dispvm, this is a rough idea
• with anon-whonix, the problem I think is that the user might have any amount of Tor VMs; I'm not sure what will be the best way of choosing one here

[alimirjamali]

• when adding this to url handling section, maybe we can also add there which dispvm template to use? Or keep using default dispvm, this is a rough idea

Both ideas are possible. I believe it is better to keep it simple at the beginning (using the default DispVM Template) and improve it further later (adding a combo box with all available DispVM templates). The latter solution will somehow automatically fix the next point (since users will be able to use whonix-workstation-xx-dvm).

• with anon-whonix, the problem I think is that the user might have any amount of Tor VMs; I'm not sure what will be the best way of choosing one here

Until the combo box idea is being implemented, program could simply check for the existence of anon-whonix. And disable its button if it does not exist.

[marmarta]

That's all a good idea - start with default dispvm template and expand later.

[alimirjamali]

This is what I have ended up so far. The ComboBox should show the Qube icons and label color. It would be easy to add.

[marmarta]

Looks great, with one small caveat: the URL here looks editable, I don't think this is a good idea? As in, it doesn't have to be editable and editability always adds a chance of footguns :)

[alimirjamali]

Looks great, with one small caveat: the URL here looks editable, I don't think this is a good idea? As in, it doesn't have to be editable and editability always adds a chance of footguns :)

It is not editable. It has editable property set to False in glade file. I made it a GtkEntry rather than a GtkLabel to allow users copy/past it to local (GUIVM) clipboard if they wish to do so. Overall this is going to be simple. For changing the (saved) default behaviour, it should go to Global Config->URL Handling?

[marmarta]

You can have a label with selectable property, to enable the copying without the "looks like it should be editable" look ( https://docs.gtk.org/gtk3/method.Label.set_selectable.html )

[marmarta]

And yeah, URL handling is a good place for this

[alimirjamali]

PR is almost ready. It only needs feature saving code of Global Config.

Here is a demo (the browser finally opened in DispVM after I stopped recording. This system is slow):

qubes-virtual-browser.mp4