Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test files are too big (they take about 20 MB) #24

Open
markotoplak opened this issue Oct 18, 2024 · 0 comments
Open

Test files are too big (they take about 20 MB) #24

markotoplak opened this issue Oct 18, 2024 · 0 comments

Comments

@markotoplak
Copy link
Contributor

markotoplak commented Oct 18, 2024

It is nice if packages include tests and test files, if possible. This package is not nice because test data is ~20MB and thus should not be distributed (it currently is, though, and it makes this package needlessly big - it is about 10MB).

It would be great if we had smaller test files (total size <1MB). This is usually easy to achieve by just taking a portion of the file in question or making a smaller measurement.

For reference, see how much I bugged Quasars/orange-spectroscopy#739

Now we screwed it up already a bit because these big files will always be in the repo history, but this is not such a problem because it does not hurt end users, just developers. Please be mindful of what you commit in the future.

@markotoplak markotoplak changed the title Test files are too big Test files are too big (they take about 20 MB) Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant