Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeater grid example and tutorial #107

Closed
wants to merge 15 commits into from

Conversation

ba2tro
Copy link
Member

@ba2tro ba2tro commented Feb 21, 2024

Resolves #101

@ba2tro ba2tro added the Skip-Changelog label for control of CI: skips the changelog check label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.34%. Comparing base (ce7dcea) to head (4d4c430).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files          37       37           
  Lines        1525     1525           
=======================================
  Hits         1088     1088           
  Misses        437      437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ba2tro ba2tro marked this pull request as ready for review April 3, 2024 20:40
@Krastanov
Copy link
Member

Krastanov commented Apr 16, 2024

I left some minor comments. After they are addressed this can be merged and the as followup this should be planned (and added to the issue tracker):

  • this deadlocks currently (as seen on the new plots that include the entanglement tracker) - that should be solved by improving the control protocols
  • the entanglement tracker needs a better interface for accessing the log (mentioned in todos)
  • an interactive webgl example should be made as well (similarly to how the other examples have interactive webgl versions). The WGLMakie + JSServe (now renamed to Bonito) are enough for that

@Krastanov
Copy link
Member

also, now that there are references in the docs, they seem to be causing documentation compilations issues -- that should be fixed too

@ba2tro ba2tro mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog label for control of CI: skips the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid entanglement simulation example
2 participants