-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal]: Better handling of MD-type jobs where a termination may not be a failure #2408
Comments
This is certainly doable. That said, I would propose that this behavior is toggleable via the global settings, such as It does not seem terribly difficult to implement. The idea would basically be to use a more flexible version of |
What new feature would you like to see?
This proposal aim to extend the work of the terminate() function by making it call a new
failed_schema()
function. Ideally this function should attempt to fetch the current available results. For example in the case of a timed-out MD, the traj and log should be read and put in a dictionary in the same way that this is already done.The problem, as mentioned by @Andrew-S-Rosen is that:
Indeed such function would need to be full or try/exception as no assumption is made on the current state of the calculation. My interpretation is that such function should not attempt to summarise results (no call to pymatgen etc...) but to barely read what is available: the calculation is not done. In the case of logfile and trajfile that's easy, the files are known. In the case of software specific files, it would be nice to come up with a solution to attempt to read them, for example by using #2407.
From the discussions in #2399
The text was updated successfully, but these errors were encountered: