-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clojurescript variants that have nodejs pre-installed? #91
Comments
Yes! I am currently using a custom Dockerfile for ClojureScript development that builds on the |
@njordhov Hmm... interesting idea. I was thinking of just creating official Thoughts @Quantisan? |
@cap10morgan a separate image sounds good to keep it clean. Otherwise, I haven't used clojurescript for ages so I don't know what toolsets are needed anymore. |
@cap10morgan A separate clojurescript image is fine, particularly when going beyond a kitchen-sink image. Thank you for all your work in making this happen. |
Please no; AFIK there is no cljs builder that uses node in process. You just need the node_modules folder. Just do like this: FROM node:alpine AS node
COPY package.json package-lock.json ./
RUN npm install
FROM openjdk-16-tools-deps-alpine
COPY --from=node node_modules node_modules
RUN clojure -A:shadow-cljs release app |
@souenzzo That's an argument for why you don't need it (not why it would be undesirable nor why others shouldn't need it). If we created it and you still didn't need it, you could just not use it. The other images aren't going away. |
@souenzzo I still have a use-case for this, using leiningen/fighweel-main which uses webpack for post-processing/bundling. |
Came here from @plexus's tip on thheller/shadow-cljs#579. The fix is just:
I've pushed it to |
This is still something I'd like to do. I think it will involve changing some fundamental assumptions in our build system, so the work involved there is the big hurdle. |
Tangental tip for those using the clojure docker image with CircleCI and wanting to add nodejs support: you can add nodejs easily enough with their node orb. Here's how I did this for cljdoc's build. |
Should we consider adding clojurescript images that pre-install node, npm, etc.?
The text was updated successfully, but these errors were encountered: