Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding the repo as a submodule by moving addons to the root. #146

Open
fire opened this issue Jan 4, 2022 · 1 comment
Open

Allow adding the repo as a submodule by moving addons to the root. #146

fire opened this issue Jan 4, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@fire
Copy link

fire commented Jan 4, 2022

Hi, any suggestions on this problem?

Context and Problem Statement

Currently I cannot directly add this repo as a submodule into my project.

I want to add this project to the Sunkper Summer Project.

Describe the proposed option and how it helps to overcome the problem or limitation

Move the files to the root.

Describe how your proposal will work, with code, pseudo-code, mock-ups, or diagrams

Go to Gitkraken, move the files so that the files are move to the root.

Like addons/qodot becomes .

Positive Consequences

  • Able to be git submoduled into the summer project

Negative Consequences

  • change is hard

Option graveyard:

  • Option: Keep as is
  • Rejection Reason: Not sure how to make the submodules work

If this enhancement will not be used often, can it be worked around with a few lines of script?

Is a git technique.

Is there a reason why this should be core and done by us?

Needs to be done by Qodot/qodot-plugin

References

@Shfty
Copy link
Member

Shfty commented Jan 4, 2022

As far as I'm aware, this is at odds with hosting on the Godot AssetLib; if i move the plugin to the root, it's going to dump itself into res:// whenever someone first adds it to their project, which is not desirable.

I've had similar issues with submodule roots before now, and the best solution I can think of to your issue is adding the repo as a submodule (for the sake of organization, etc), then symlinking its plugin subfolder to res://addons/qodot.

@DeerTears DeerTears added the enhancement New feature or request label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants