Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate steiner_tree() and metric_closure() to rustworkx-core #769

Closed
mtreinish opened this issue Jan 3, 2023 · 5 comments
Closed

Migrate steiner_tree() and metric_closure() to rustworkx-core #769

mtreinish opened this issue Jan 3, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mtreinish
Copy link
Member

What is the expected enhancement?

The metric_closure() and steiner_tree() functions available at: https://github.com/Qiskit/rustworkx/blob/main/src/steiner_tree.rs should be straightforward to port to rustworkx-core and rework as generic for any petgraph graph and then update the python functions to call the inner rustworkx-core function. This will then expose this functionality to any rust users that might want this functionality.

@mtreinish mtreinish added good first issue Good for newcomers enhancement New feature or request labels Jan 3, 2023
@tapanih
Copy link
Contributor

tapanih commented Jan 30, 2023

I noticed that metric_closure uses all_pairs_dijkstra_shortest_paths so that function needs to be moved as well.

@yoshida-ryuhei
Copy link
Contributor

Can I be assigned to this?

@mtreinish
Copy link
Member Author

Sure thing, I've assigned the issue to you

@yoshida-ryuhei
Copy link
Contributor

Thank you.
I am going to implement this patch!

@mtreinish
Copy link
Member Author

This was implemented in #1103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants