Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transitive closure #704

Open
LaurentBergeron opened this issue Oct 19, 2022 · 2 comments · May be fixed by #1257
Open

Transitive closure #704

LaurentBergeron opened this issue Oct 19, 2022 · 2 comments · May be fixed by #1257
Assignees
@Procatv
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@LaurentBergeron
Copy link

What is the expected enhancement?

Implementing a transitive closure function with similar functionality to the one in Networkx:

https://networkx.org/documentation/stable/reference/algorithms/generated/networkx.algorithms.dag.transitive_closure.html
@IvanIsCoding IvanIsCoding added good first issue Good for newcomers enhancement New feature or request labels Oct 20, 2022
mtreinish added a commit to mtreinish/retworkx that referenced this issue Oct 20, 2022
@mtreinish
Add transitive_closure_dag function
dc16084 
This commit adds a new function transitive_closure_dag() which is an
optimized method for computing the transitive closure for DAGs. In
support of this a new function descendants_at_distance() for finding the
nodes a fixed distance from a given source to both rustworkx and
rustworkx-core.

Related to: Qiskit#704
@mtreinish mtreinish mentioned this issue Oct 20, 2022
Open
1 task
@mtreinish
Copy link
Member

I just opened up #707 which did the DAG optimized form of this function. Primarily because it looked more fun for me to implement, but I didn't mark that as closing this because it's not the general form which works with any graph. So if someone still wants to work on that they should feel free

@IvanIsCoding IvanIsCoding added the help wanted Extra attention is needed label Jan 9, 2024
@Procatv
Copy link
Contributor

Procatv commented Jun 20, 2024

Can I be assigned, I'd like to take a look at this issue

@Procatv Procatv linked a pull request Jul 29, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Procatv Procatv

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added general form of transitive closure Procatv/rustworkx
4 participants
@mtreinish @IvanIsCoding @LaurentBergeron @Procatv