Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Provider to ServerlessProvider #989

Closed
caleb-johnson opened this issue Oct 2, 2023 · 3 comments · Fixed by #1011
Closed

Rename Provider to ServerlessProvider #989

caleb-johnson opened this issue Oct 2, 2023 · 3 comments · Fixed by #1011
Assignees
@caleb-johnson
Labels
enhancement New feature or request project: client Label to identify features related with client project
Milestone
0.7

Comments

@caleb-johnson
Copy link
Collaborator

It has been suggested to renamed Provider to ServerlessProvider to avoid confusion with other providers in the Qiskit ecosystem. This issue is to discuss that topic.
@caleb-johnson
Copy link
Collaborator Author

caleb-johnson commented Oct 2, 2023 •
edited
Loading

If we are going to do a small release to include #944 , this would be another thing that would be straightforward to include -- assuming we want to go ahead with renaming this class.

@jenglick @IceKhan13 , do you have any thoughts? The intention was to just rename our base provider class to ServerlessProvider, right?

@caleb-johnson caleb-johnson added enhancement New feature or request project: gateway Label to identify features related with gateway project and removed project: gateway Label to identify features related with gateway project labels Oct 2, 2023
@psschwei
Copy link
Collaborator

psschwei commented Oct 2, 2023

Is this a new change? (we initially renamed to Provider in #322 )

@jenglick
Copy link
Collaborator

jenglick commented Oct 2, 2023

Yes, I think we should differentiate from other IBM providers -- and ServerlessProvider is an option we could use for now for the "default" provider option

@IceKhan13 IceKhan13 added this to the 0.7 milestone Oct 3, 2023
@IceKhan13 IceKhan13 added the project: client Label to identify features related with client project label Oct 3, 2023
@caleb-johnson caleb-johnson self-assigned this Oct 4, 2023
@caleb-johnson caleb-johnson mentioned this issue Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caleb-johnson caleb-johnson

Labels
enhancement New feature or request project: client Label to identify features related with client project
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

Change Provider class name to ServerlessProvider caleb-johnson/quantum-serverless
4 participants
@IceKhan13 @caleb-johnson @jenglick @psschwei