Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate current deprecated CUDA build system to native language support in CMake #843

Closed
atilag opened this issue Jul 24, 2020 · 1 comment
Labels
build system enhancement New feature or request

Comments

@atilag
Copy link
Member

atilag commented Jul 24, 2020

With the inclusion of SIMD in our codebase, we build parts of the code with SIMD support, and other parts without it.
There seems to be a bug in FindCUDA.cmake that doesn't allow us to build files with specific compiler flags, so we cannot set the SIMD flags for the parts of the code that supports it, we have to set these flags "globally" for the cmake target and this will conflict with systems running Aer with no SIMD support.

What is the expected behavior?

The new way to build CUDA files in CMake allow us to set different flags to different source code files, so we should migrate our current CUDA build implementation to this new one.

@vvilpas
Copy link
Contributor

vvilpas commented Nov 24, 2020

Implemented in #859

@vvilpas vvilpas closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants