Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impropve flaky unittest #39

Open
mrossinek opened this issue Nov 8, 2024 · 0 comments
Open

Impropve flaky unittest #39

mrossinek opened this issue Nov 8, 2024 · 0 comments
Labels
test Regarding tests and test automation

Comments

@mrossinek
Copy link
Member

The test_backpropagate_timeout can be quite flaky at times. Specifically, the check which asserts that the time spent on backpropagation is smaller than the specific maximum limit:

assert (t2 - t1) < 2

We should consider ways of removing this flakiness in a way that is not affected by performance improvements of the underlying code (if that is possible).

@mrossinek mrossinek added the test Regarding tests and test automation label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Regarding tests and test automation
Projects
None yet
Development

No branches or pull requests

1 participant