Support prefixes 0X, 0O, 0B for hex, octal, binary literals
#232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Qiskit#226 Previously, literals with prefix `0x` were parsed and analyzed correctly. But literals with prefix `0X` were analyzed as value `0`. This is now fixed. Prefixes `0B` and `0O` were broken in the same way and are now fixed. This fix also uncovers a bug that will be opened and fixed separately: Illegal (nonsense) integer literals, with prefixes such as 0Q will be analyzed as valid, decimal, literals. Instead they should cause an error to be logged. A lex, or possibly parse, error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226
Previously, literals with prefix
0xwere parsed and analyzed correctly. But literalswith prefix
0Xwere analyzed as value0. This is now fixed. Prefixes0Band0Owere broken in the same way and are now fixed.
This fix also uncovers a bug that will be opened and fixed separately: Illegal (nonsense)
integer literals, with prefixes such as
0Qwill be analyzed as valid, decimal,literals. They should instead cause an error to be logged. A lex-, or possibly parse,
error.