Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submission]: qdao #532

Closed
Zhaoyilunnn opened this issue Sep 14, 2023 · 22 comments · Fixed by #533
Closed

[Submission]: qdao #532

Zhaoyilunnn opened this issue Sep 14, 2023 · 22 comments · Fixed by #533
Labels
ready submission Project submission

Comments

@Zhaoyilunnn
Copy link
Contributor

Zhaoyilunnn commented Sep 14, 2023

Github repo

https://github.com/Zhaoyilunnn/qdao

Description

A lightweight framework to enable configurable memory consumption when simulating large quantum circuits.

Email

[email protected]

Alternatives

No response

License

Apache License 2.0

Affiliations

Institute of Computing Technology, Chinese Academy of Sciences.

Labels

Circuit simulator

Website

No response

@Zhaoyilunnn Zhaoyilunnn added the submission Project submission label Sep 14, 2023
@github-actions github-actions bot added the on hold Waiting for action from third party label Sep 14, 2023
@github-actions
Copy link
Contributor

Standard tests

❌ The submission didn't pass the standard check.
Please follow minimal requirements for project or/and add ecosystem.json configuration in the root of the project.
Read more here https://github.com/qiskit-community/ecosystem/blob/main/docs/project_overview.md#adding-project-to-the-ecosystem.

Stable tests

⚠️ The submission didn't pass the stable check.
This means your project doesn't work with the latest version of Qiskit.
This is purely informational and doesn't affect your project joining the Ecosystem, but you may want to investigate the problem.

Development tests

⚠️ The submission didn't pass the development check.
This means your project might not work with the next version of Qiskit.
This is purely informational and doesn't affect your project joining Ecosystem.


Logs: https://github.com/qiskit-community/ecosystem/actions/runs/6180919760
PR #533

@mickahell
Copy link
Collaborator

Hi @Zhaoyilunnn :)

I saw your comment in the PR, we will see how we can manage that.
In the mean time, didn't you find any label that could correspond to your project at all ? If no, do you have suggestion for a label we could add ?

@Zhaoyilunnn
Copy link
Contributor Author

Hi @Zhaoyilunnn :)

I saw your comment in the PR, we will see how we can manage that. In the mean time, didn't you find any label that could correspond to your project at all ? If no, do you have suggestion for a label we could add ?

Hi @mickahell , thanks for the quick response. Sorry I missed the label section, after checking, I think qdao belongs to "Circuit simulator".

@mickahell
Copy link
Collaborator

Hi @mickahell , thanks for the quick response. Sorry I missed the label section, after checking, I think qdao belongs to "Circuit simulator".

Can you edit your submission and add it please.

I update the tox file in my fork in order to take every GitHub Actions env var.
In my dry run I have this error :

ValueError: Cannot load qasm file random_12_9_max_operands_2_gen.qasm: [Errno 2] No such file or directory: '/home/runner/work/ecosystem/ecosystem/ecosystem/resources/cloned_repo_directory/qdao/qcs/benchmarks/qasm/random_12_9_max_operands_2_gen.qasm'

Log : https://github.com/mickahell/ecosystem/actions/runs/6212754899/job/16863200377#step:8:159

@mickahell
Copy link
Collaborator

mickahell commented Sep 17, 2023

Oh ok I saw why, you set the qcs folder in your tox :

python -c "import os; os.path.exists('{toxinidir}/qcs') or os.system('git clone https://github.com/Zhaoyilunnn/qcs.git {toxinidir}/qcs')"

Why do you do this in your tox and not in your tests as def setUp(self) -> None: ?

Example :
https://github.com/qiskit-community/ecosystem/blob/9c24cca89a1aa51070799fe70d340f8b12fbf5b4/tests/utils/test_utils.py#L14-L19

En then you can delete everything at the end of your test :
https://github.com/qiskit-community/ecosystem/blob/9c24cca89a1aa51070799fe70d340f8b12fbf5b4/tests/runners/test_runner.py#L20-L25

@Zhaoyilunnn
Copy link
Contributor Author

Oh ok I saw why, you set the qcs folder in your tox :

python -c "import os; os.path.exists('{toxinidir}/qcs') or os.system('git clone https://github.com/Zhaoyilunnn/qcs.git {toxinidir}/qcs')"

Why do you do this in your tox and not in your tests as def setUp(self) -> None: ?

Example :

https://github.com/qiskit-community/ecosystem/blob/9c24cca89a1aa51070799fe70d340f8b12fbf5b4/tests/utils/test_utils.py#L14-L19

En then you can delete everything at the end of your test :

https://github.com/qiskit-community/ecosystem/blob/9c24cca89a1aa51070799fe70d340f8b12fbf5b4/tests/utils/test_utils.py#L14-L19

Got it, thanks a lot! I will fix this issue and get back to you.

@mickahell
Copy link
Collaborator

mickahell commented Sep 17, 2023

Got it, thanks a lot! I will fix this issue and get back to you.

No problem :)

If you want to run something at the end of your tests you can also add :
https://github.com/qiskit-community/ecosystem/blob/9c24cca89a1aa51070799fe70d340f8b12fbf5b4/tests/runners/test_runner.py#L20-L25

Basically tearDown is running at the end and setUp at the start, both automatically by pytest

@Zhaoyilunnn
Copy link
Contributor Author

Hi @mickahell, I have fixed qcs setting issue and added the label. Please check it. Thanks!

@mickahell
Copy link
Collaborator

Hi @mickahell, I have fixed qcs setting issue and added the label. Please check it. Thanks!

You were fast !
I'm testing it in my fork

@github-actions
Copy link
Contributor

Standard tests

❌ The submission didn't pass the standard check.
Please follow minimal requirements for project or/and add ecosystem.json configuration in the root of the project.
Read more here https://github.com/qiskit-community/ecosystem/blob/main/docs/project_overview.md#adding-project-to-the-ecosystem.

Stable tests

⚠️ The submission didn't pass the stable check.
This means your project doesn't work with the latest version of Qiskit.
This is purely informational and doesn't affect your project joining the Ecosystem, but you may want to investigate the problem.

Development tests

⚠️ The submission didn't pass the development check.
This means your project might not work with the next version of Qiskit.
This is purely informational and doesn't affect your project joining Ecosystem.


Logs: https://github.com/qiskit-community/ecosystem/actions/runs/6213049205
PR #533

@mickahell
Copy link
Collaborator

mickahell commented Sep 17, 2023

New error :

tests/qdao/engine_test.py::TestEngine::test_run_qiskit_any_qasm[random_12_9_max_operands_2_gen.qasm-12-10-8-QDAO-1-1-CPU-disk] - PermissionError: [Errno 13] Permission denied: '/root/projects/qcs'

Log : https://github.com/mickahell/ecosystem/actions/runs/6213059508/job/16863769683#step:6:251

@Zhaoyilunnn
Copy link
Contributor Author

New error :

tests/qdao/engine_test.py::TestEngine::test_run_qiskit_any_qasm[random_12_9_max_operands_2_gen.qasm-12-10-8-QDAO-1-1-CPU-disk] - PermissionError: [Errno 13] Permission denied: '/root/projects/qcs'

Log : https://github.com/mickahell/ecosystem/actions/runs/6213059508/job/16863769683#step:6:251

I see it and have fixed it. Thanks

@mickahell
Copy link
Collaborator

I see it and have fixed it. Thanks

Ok I'm sending a new dry run

@Zhaoyilunnn
Copy link
Contributor Author

Zhaoyilunnn commented Sep 17, 2023

I see it and have fixed it. Thanks

Ok I'm sending a new dry run

Thanks. I will add a github action in my repo to avoid mistakes corresponding to local development environment...

Seems that it is ready now! Thanks for your help

@mickahell
Copy link
Collaborator

Thanks. I will add a github action in my repo to avoid mistakes corresponding to local development environment...

Success 🥳 Summary result : https://github.com/mickahell/ecosystem/actions/runs/6213099084/attempts/1#summary-16863841344
Everything seems to works fine now :)

From what I see from our check result is you could also use the latest qiskit version : 0.44.1

Don't forget to add in your tox this line passenv = * under [testenv] in order to pass every env var from Actions to tox.

@mickahell
Copy link
Collaborator

And now in order to your submission to pass. It just need to merge this PR #537 , gonna be merge during next week I guess.

@Zhaoyilunnn
Copy link
Contributor Author

Thanks. I will add a github action in my repo to avoid mistakes corresponding to local development environment...

Success 🥳 Summary result : https://github.com/mickahell/ecosystem/actions/runs/6213099084/attempts/1#summary-16863841344 Everything seems to works fine now :)

From what I see from our check result is you could also use the latest qiskit version : 0.44.1

Don't forget to add in your tox this line passenv = * under [testenv] in order to pass every env var from Actions to tox.

Sure! Thanks for reminding, btw I checked that the dev version test failed, but the issue can also be fixed. We will keep pace with qiskit development and make it compatible with latest qiskit version.

@mickahell
Copy link
Collaborator

For the submission the minimal requirements is to pass the standard check. If can pass stable as well is great and if pass all 3 that's perfect :D and means your program is very strong and should be able to evolve through Qiskit evolution 🚀

@Zhaoyilunnn
Copy link
Contributor Author

For the submission the minimal requirements is to pass the standard check. If can pass stable as well is great and if pass all 3 that's perfect :D and means your program is very strong and should be able to evolve through Qiskit evolution 🚀

Thanks for the illustration, I think the dev version test should also be passed now :)

@mickahell
Copy link
Collaborator

Thanks for the illustration, I think the dev version test should also be passed now :)

Congrat's : https://github.com/mickahell/ecosystem/actions/runs/6213616184/attempts/1#summary-16864837484 ;)

@github-actions github-actions bot added ready and removed on hold Waiting for action from third party labels Sep 18, 2023
@github-actions
Copy link
Contributor

Standard tests

✨ Successfull submission!

Stable tests

✨ Tests with latest version of Qiskit release passed!

Development tests

✨ Tests with development version of Qiskit release passed!


Logs: https://github.com/qiskit-community/ecosystem/actions/runs/6218254961
PR #533

frankharkins added a commit that referenced this issue Sep 18, 2023
Add qdao to list.

---
Closes #532

Co-authored-by: Zhaoyilunnn <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
@github-actions
Copy link
Contributor

hello @Zhaoyilunnn! You joined the Qiskit Ecosystem a little while ago and I just wanted to check in and let you know of some follow up actions you can take to make the most of joining the program, if you're interested:

💬 Join other Qiskit ecosystem developers in the Slack channel #qiskit-ecosystem (if you are not in the Qiskit workspace yet, you can sign up here: https://qisk.it/join-slack)

🧠 Help us define the future of the Qiskit Ecosystem: we recently started an RFC on how the Ecosystem should be structured. It is very draft-y at the moment, but you can subscribe for notifications here Qiskit/RFCs#46 to participate in that discussion.

📣 Would you like to showcase your project to the Qiskit community? A couple of things you can do to raise awareness for your project:

Great having you as a part of the ecosystem!

frankharkins pushed a commit that referenced this issue Sep 18, 2023
<!--
⚠️ If you do not respect this template, your pull request will be
closed.
⚠️ Your pull request title should be short detailed and understandable
for all.
⚠️ Also, please add a release note file using reno if the change needs
to be
  documented in the release notes.
⚠️ If your pull request fixes an open issue, please link to the issue.

- [ ] I have added the tests to cover my changes.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
-->

### Summary

Allow the possibility to pass environment var from GitHub Actions to
tox.


### Details and comments

- [x] Update tox tpl
- [x] Test [Dry run from
fork](https://github.com/mickahell/ecosystem/actions/runs/6213099084/attempts/1#summary-16863841344)

---
Closes #536 
Related #532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready submission Project submission
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants