-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Submission]: qdao #532
Comments
Standard tests❌ The submission didn't pass the standard check. Stable tests
Development tests
Logs: https://github.com/qiskit-community/ecosystem/actions/runs/6180919760 |
Hi @Zhaoyilunnn :) I saw your comment in the PR, we will see how we can manage that. |
Hi @mickahell , thanks for the quick response. Sorry I missed the label section, after checking, I think qdao belongs to "Circuit simulator". |
Can you edit your submission and add it please. I update the tox file in my fork in order to take every GitHub Actions env var. ValueError: Cannot load qasm file random_12_9_max_operands_2_gen.qasm: [Errno 2] No such file or directory: '/home/runner/work/ecosystem/ecosystem/ecosystem/resources/cloned_repo_directory/qdao/qcs/benchmarks/qasm/random_12_9_max_operands_2_gen.qasm' Log : https://github.com/mickahell/ecosystem/actions/runs/6212754899/job/16863200377#step:8:159 |
Oh ok I saw why, you set the python -c "import os; os.path.exists('{toxinidir}/qcs') or os.system('git clone https://github.com/Zhaoyilunnn/qcs.git {toxinidir}/qcs')" Why do you do this in your tox and not in your tests as En then you can delete everything at the end of your test : |
Got it, thanks a lot! I will fix this issue and get back to you. |
No problem :) If you want to run something at the end of your tests you can also add : Basically |
Hi @mickahell, I have fixed |
You were fast ! |
Standard tests❌ The submission didn't pass the standard check. Stable tests
Development tests
Logs: https://github.com/qiskit-community/ecosystem/actions/runs/6213049205 |
New error : tests/qdao/engine_test.py::TestEngine::test_run_qiskit_any_qasm[random_12_9_max_operands_2_gen.qasm-12-10-8-QDAO-1-1-CPU-disk] - PermissionError: [Errno 13] Permission denied: '/root/projects/qcs' Log : https://github.com/mickahell/ecosystem/actions/runs/6213059508/job/16863769683#step:6:251 |
I see it and have fixed it. Thanks |
Ok I'm sending a new dry run |
Thanks. I will add a github action in my repo to avoid mistakes corresponding to local development environment... Seems that it is ready now! Thanks for your help |
Success 🥳 Summary result : https://github.com/mickahell/ecosystem/actions/runs/6213099084/attempts/1#summary-16863841344 From what I see from our check result is you could also use the latest qiskit version : Don't forget to add in your tox this line |
And now in order to your submission to pass. It just need to merge this PR #537 , gonna be merge during next week I guess. |
Sure! Thanks for reminding, btw I checked that the dev version test failed, but the issue can also be fixed. We will keep pace with qiskit development and make it compatible with latest qiskit version. |
For the submission the minimal requirements is to pass the standard check. If can pass stable as well is great and if pass all 3 that's perfect :D and means your program is very strong and should be able to evolve through Qiskit evolution 🚀 |
Thanks for the illustration, I think the dev version test should also be passed now :) |
Congrat's : https://github.com/mickahell/ecosystem/actions/runs/6213616184/attempts/1#summary-16864837484 ;) |
Standard tests✨ Successfull submission! Stable tests✨ Tests with latest version of Qiskit release passed! Development tests✨ Tests with development version of Qiskit release passed! Logs: https://github.com/qiskit-community/ecosystem/actions/runs/6218254961 |
Add qdao to list. --- Closes #532 Co-authored-by: Zhaoyilunnn <[email protected]> Co-authored-by: Frank Harkins <[email protected]>
hello @Zhaoyilunnn! You joined the Qiskit Ecosystem a little while ago and I just wanted to check in and let you know of some follow up actions you can take to make the most of joining the program, if you're interested: 💬 Join other Qiskit ecosystem developers in the Slack channel #qiskit-ecosystem (if you are not in the Qiskit workspace yet, you can sign up here: https://qisk.it/join-slack) 🧠 Help us define the future of the Qiskit Ecosystem: we recently started an RFC on how the Ecosystem should be structured. It is very draft-y at the moment, but you can subscribe for notifications here Qiskit/RFCs#46 to participate in that discussion. 📣 Would you like to showcase your project to the Qiskit community? A couple of things you can do to raise awareness for your project:
Great having you as a part of the ecosystem! |
<!--⚠️ If you do not respect this template, your pull request will be closed.⚠️ Your pull request title should be short detailed and understandable for all.⚠️ Also, please add a release note file using reno if the change needs to be documented in the release notes.⚠️ If your pull request fixes an open issue, please link to the issue. - [ ] I have added the tests to cover my changes. - [ ] I have updated the documentation accordingly. - [ ] I have read the CONTRIBUTING document. --> ### Summary Allow the possibility to pass environment var from GitHub Actions to tox. ### Details and comments - [x] Update tox tpl - [x] Test [Dry run from fork](https://github.com/mickahell/ecosystem/actions/runs/6213099084/attempts/1#summary-16863841344) --- Closes #536 Related #532
Github repo
https://github.com/Zhaoyilunnn/qdao
Description
A lightweight framework to enable configurable memory consumption when simulating large quantum circuits.
Email
[email protected]
Alternatives
No response
License
Apache License 2.0
Affiliations
Institute of Computing Technology, Chinese Academy of Sciences.
Labels
Circuit simulator
Website
No response
The text was updated successfully, but these errors were encountered: