Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] Qiskit Functions: decide if we want to test any of the notebooks #1951

Open
Eric-Arellano opened this issue Sep 16, 2024 · 2 comments

Comments

@Eric-Arellano
Copy link
Collaborator

Eric-Arellano commented Sep 16, 2024

We skip all of the notebooks by setting notebooks_exclude in notebook-testing.toml. Should we test any of these?

Update: sync with David, Iskander, and Sanket about what they think is reasonable. We should also consider #1173 or adding Pylint.

@frankharkins
Copy link
Member

frankharkins commented Sep 20, 2024

Discussed in meeting: We could try a static analysis tool like pylint to detect things like undefined variables and typos in module names. Related to #1806.

Update: We've now added Ruff linting

@frankharkins
Copy link
Member

I spoke to @johannesgreiner today about this. Most functions take a backend name (str) rather than a backend object, which means our least_busy patch won't work. Here's what we're thinking:

  1. To start, we'll try testing the functions notebooks in the fortnightly cron job. We may need a bit of extra code to find/replace standardized strings like <YOUR_API_TOKEN> and <YOUR_IQP_GROUP>, and some notebooks will need tweaking to run from start to finish (see Test functions notebooks in fortnightly cron job #2239 for full issue).

  2. We can test functions that don't post-process results using the IBM test backends. This will submit jobs that should run very quickly and return nonsense results. We'll need to add some more patching code, but it'll hopefully mean we can test these notebooks on PR, which would be great (full issue: Use testing backends with functions notebooks #2240)

@Eric-Arellano Eric-Arellano changed the title Qiskit Functions: decide if we want to test any of the notebooks [epic] Qiskit Functions: decide if we want to test any of the notebooks Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants