Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Walker.h constructors #5068

Open
ye-luo opened this issue Jun 28, 2024 · 0 comments
Open

Revisit Walker.h constructors #5068

ye-luo opened this issue Jun 28, 2024 · 0 comments

Comments

@ye-luo
Copy link
Contributor

ye-luo commented Jun 28, 2024

Both constructors and copy constructors have variants with walker_id and parent_id as arguments.
Given there are setXXXid APIs. probably we should simplify them. See #5063 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant