-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SlaterDetBuilder I/O issues #5013
Comments
Fair points. Reading and bcasting probably most impactful. I would add (3) Repeated code and (4) Lack of input validation as well. It is very trusting of the input. However it does work for present day-to-day purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not necessarily bugs but a few things need to be better handled in https://github.com/QMCPACK/qmcpack/blob/develop/src/QMCWaveFunctions/Fermion/SlaterDetBuilder.cpp
The text was updated successfully, but these errors were encountered: