Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing cards in web series, movies and kids page #484

Closed

Conversation

JahnaviKashyap19
Copy link
Contributor

@JahnaviKashyap19 JahnaviKashyap19 commented Jul 30, 2021

Fixes #241

Describe the changes you've made

Made the movies, web series and kids' pages similar to the other pages.

Added Video reference for the changes made

video.mp4

Checklist

  • The title of my pull request is a short description of the requested changes.
  • My code follows the code style of this project.
  • Open Source Program name(LGMSoC'21)

@QAZIMAAZARSHAD
Copy link
Owner

@JahnaviKashyap19 resolve conflicts, fetch upstream.

Also share a live website link so I can review your changes.

@JahnaviKashyap19
Copy link
Contributor Author

@QAZIMAAZARSHAD I have made the changes please review it.

@QAZIMAAZARSHAD
Copy link
Owner

Share website link for review.

@QAZIMAAZARSHAD QAZIMAAZARSHAD changed the title Issue #241 changes Changing cards in web series, movies and kids page Aug 2, 2021
@QAZIMAAZARSHAD
Copy link
Owner

Also fetch upstream

@QAZIMAAZARSHAD
Copy link
Owner

Resolve conflicts.

And share a live website link for review.

@JahnaviKashyap19
Copy link
Contributor Author

JahnaviKashyap19 commented Aug 6, 2021 via email

@QAZIMAAZARSHAD
Copy link
Owner

Host your website on any platform like Repl.it, Netlify, or GitHub pages.

Then share the link.

For GitHub Pages - Just go to the settings on your repository, scroll down to GitHub pages, Click, you will get your link.

@QAZIMAAZARSHAD
Copy link
Owner

And resolve conflicts. Fetch upstream.

Your repo is 13 commits behind.

@QAZIMAAZARSHAD
Copy link
Owner

@JahnaviKashyap19 if PR is merged after today then it will not be considered for LGM-SoC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make movie cards in Kids, Web-Series and Movies page similar to Genre pages like Action, Crime, etc.
2 participants