Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Update PlaceholderAPI #358

Closed
PyvesB opened this issue May 26, 2018 · 8 comments · Fixed by #383
Closed

Update PlaceholderAPI #358

PyvesB opened this issue May 26, 2018 · 8 comments · Fixed by #383
Labels
developer experience Let's reduce the project's technical debt or make things easier for developers!

Comments

@PyvesB
Copy link
Owner

PyvesB commented May 26, 2018

The current version of the PlaceholderAPI dependency used in Advanced Achievements is 2.8.2, but the latest available is 2.8.7. I tried bumping the version number up, but noticed that some methods had since then been deprecated.

@Phoetrix , as you're our PlaceholderAPI expert, would you like to look into this and see whether you can upgrade to the latest version? 😃

@PyvesB PyvesB added the developer experience Let's reduce the project's technical debt or make things easier for developers! label May 26, 2018
@Phoetrix
Copy link
Contributor

Oh yes! :)
I will return to Minecraft around mid-June so I will check that at this moment.
Don't hesitate to remind me if I forget. ;)

@TheSenseiNL
Copy link

remind

@PyvesB
Copy link
Owner Author

PyvesB commented Jun 13, 2018

@TheSenseiNL I don't think there's any rush here, as it's only about keeping things up-to-date and easy to maintain rather than adding brand new functionality. ^^

@PyvesB PyvesB assigned PyvesB and unassigned PyvesB Jun 17, 2018
PyvesB pushed a commit that referenced this issue Jul 8, 2018
@PyvesB
Copy link
Owner Author

PyvesB commented Jul 8, 2018

@TheSenseiNL would you like to test the updated implementation? I can compile the plugin with the latest changes if you want.

@Phoetrix you may be interested with issue #365, as @supertassu has completed work on this issue! 😉

@Phoetrix
Copy link
Contributor

Phoetrix commented Jul 9, 2018

Oh sorry I forgot ! :o
I was very busy on June. ^^'

But ok nice! Good job @supertassu ! :)

@TheSenseiNL
Copy link

TheSenseiNL commented Jul 9, 2018

Hi, sorry I couldn't respond faster but I've been very busy. I am able to install and test it tomorow and give it a day or 2 to test it :-)
Then i'll let you know asap

@supertassu
Copy link
Contributor

Thanks @TheSenseiNL!

@PyvesB
Copy link
Owner Author

PyvesB commented Jul 9, 2018

Here's a compiled version for you:
AdvancedAchievements.zip

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
developer experience Let's reduce the project's technical debt or make things easier for developers!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants