Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update or remove __all__ declarations #457

Open
jvanasco opened this issue Dec 6, 2023 · 0 comments
Open

update or remove __all__ declarations #457

jvanasco opened this issue Dec 6, 2023 · 0 comments

Comments

@jvanasco
Copy link
Contributor

jvanasco commented Dec 6, 2023

Many of the files in WebOb declare __all__ for exports. This can create problems with the current generation of type checkers, as they may not be able to see functions that do not appear in these declarations. For example, in webob.cookies, parse_cookie is not declared.

The __all__ declarations are only used for * imports - which are increasingly unused in exchange for explicit imports.

I would be happy to generate a PR for either situation, however I would prefer dropping __all__.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant