Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wsgi.file_wrapper support in WebOb #408

Open
digitalresistor opened this issue Dec 18, 2019 · 0 comments
Open

Implement wsgi.file_wrapper support in WebOb #408

digitalresistor opened this issue Dec 18, 2019 · 0 comments

Comments

@digitalresistor
Copy link
Member

Side note, it probably wouldn't be a bad idea to add https://github.com/Pylons/pyramid/blob/85900228894814105aa882e1e71f1e4e69090a9e/pyramid/response.py#L32-L77 to webob which supports wsgi.file_wrapper which can use sendfile on conforming wsgi servers to avoid even reading the data in the worker threads.

It only supports the extension if you give it the request environ, but in theory that's solvable with better integration which can override __call__(self, environ, start_response) and grab it at render time.

Originally posted by @mmerickel in #360 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant