Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new quasi-functional test using 'multipart' #22

Merged
merged 6 commits into from
May 18, 2024
Merged

Add a new quasi-functional test using 'multipart' #22

merged 6 commits into from
May 18, 2024

Commits on May 16, 2024

  1. tests: reorder / rename fixtures for clarity

    @tseaver
    tseaver committed May 16, 2024
    Configuration menu
    Copy the full SHA
    08daf42 View commit details
    Browse the repository at this point in the history

  2. tests: add another quasi-functional tests usting 'multipart' 

    peppercorn doesn't actually *use* the deprecated stdlib's
deprecated 'cgi.FieldStorage', except in a quasi-functional test
which builds one only to tear out the name-value pairs to hand to
peppercorn's own 'parse'.

The rationale here is that peppercorn is mostly used to parse serialized
form data, passed in an HTTP POST request body encoded as
'multipart/form-data'.

Because 'peppercorn' sits in the part of the WSGI space dependent mostly
dominated by 'WebOb', which still using 'cgi.FieldStorage', we have wanted
to demonstrate that we could consume such data trivially.

However, the 'cgi' module is slated to be removed from the standard
library in Python 3.13 (see: https://peps.python.org/pep-0594/#cgi).

This branch therefore adds a similar quasi-functionl test, using instead
the 'MultipartParser' from the third-party 'multipart' package.
    @tseaver
    tseaver committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3053147 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into tseaver-test_w_multipart

    @tseaver
    tseaver committed May 16, 2024
    Configuration menu
    Copy the full SHA
    31d1d2d View commit details
    Browse the repository at this point in the history

  4. tests: refactor to highlight similarity

    @tseaver
    tseaver committed May 16, 2024
    Configuration menu
    Copy the full SHA
    28c7378 View commit details
    Browse the repository at this point in the history

  5. tests: ensure pass on 'py313' 

    Which is not yet in the 'tox.ini'.
    @tseaver
    tseaver committed May 16, 2024
    Configuration menu
    Copy the full SHA
    67ae717 View commit details
    Browse the repository at this point in the history

  6. tests: use correct fixture name 

    H/t @fschulze.
    @tseaver
    tseaver committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f442835 View commit details
    Browse the repository at this point in the history