-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ripple never disappears after click and drag #21
Comments
This also happens when you just right-click |
Any plan to fix this issue? |
Yep, this is an issue and ideas? |
I think I'll give it a go over the weekend |
Awesome, with that final touch this directive will be ace |
looks like it's been fixed here |
@ma7moudat oh, well. Still not merged =( |
Was this ripple.js file not reflected in the latest version? |
@2ju2 nop, still waiting for merge. Looks like this project is dead. Maybe I'll fork the lib and apply this change for myself. |
Your changes to the button tag will not work |
I solved this problem. Hoping the author will merge my changes into the project. https://github.com/PygmySlowLoris/vue-ripple-directive/pull/31/files |
When using the default
mousedown
event, if the user clicks on the rippled element and (without releasing) drags the cursor outside the element, the ripple just stays there and doesn't disappear like it's supposed to.Codepen example:
https://codepen.io/7oot/pen/OEgmML
After a few clicks & drags, you'd get multiple ripple containers stacked on top of each other and all disappear after a normal click & release.
The text was updated successfully, but these errors were encountered: