Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch deprecated implicit eq for simple enums #4730

Merged
merged 1 commit into from
Nov 27, 2024
Merged

switch deprecated implicit eq for simple enums #4730

merged 1 commit into from
Nov 27, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Nov 25, 2024

This remove the deprecated implicit eq fallback for simple enums.

davidhewitt
davidhewitt reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! Potentially remove the UI test inputs which no longer trigger anything?

@Icxolu
Copy link
Contributor Author

Icxolu commented Nov 26, 2024

Makes sense 👍 I think it's just the deprecation test.

davidhewitt
davidhewitt approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@davidhewitt davidhewitt added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Nov 27, 2024
Merged via the queue into PyO3:main with commit 7bd8df8 Nov 27, 2024
45 of 46 checks passed
@Icxolu Icxolu deleted the implicit-eq branch November 27, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@LilyFoote LilyFoote LilyFoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Icxolu @LilyFoote @davidhewitt