-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reintroduce PyModule
constructors
#4404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! I found a few URLs in the docs that need updating, plus some additional migration opportunities around &CStr
that we should discuss about.
97f7d2d
to
c5d05d9
Compare
Sorry for the late reply. Had to find time to do opensource again. I updated the implementation as of your suggestions. The change on the |
4d34e37
to
fecbe59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing this off!
Sorry for the late reply. Had to find time to do opensource again.
No worries
The change on the
from_code
method is breaking I guess, so should I add a changelog + migration guide entry as well?
Since this is only breaking, once the users already touched the code to migrate from from_code_bound
to from_code
, I think a changelog entry mentioning this should suffice for now. I suspect that we will have a few more migrations of this kind, so we can add a general migration entry once we collected them all.
I've added the changelog entry |
fecbe59
to
f5f9eee
Compare
Perfect, thanks! |
No description provided.