Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up deprecation message on bound api #3893

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

dmatos2012
Copy link
Contributor

Fixes #3891. Not much to this, just bit of clean up suggested today on stream. Motivation is that this way is clearer, and if user wants to know more, they can check docs or elsewhere for more information on the reason for deprecation.

@LilyFoote LilyFoote added the CI-skip-changelog Skip checking changelog entry label Feb 23, 2024
Copy link
Contributor

@LilyFoote LilyFoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ✨

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Feb 24, 2024
Merged via the queue into PyO3:main with commit 0f29fec Feb 24, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidy up Bound API deprecation messages
3 participants