Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new_closure_bound closure signature #3883

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Update new_closure_bound closure signature #3883

merged 3 commits into from
Feb 23, 2024

Conversation

LilyFoote
Copy link
Contributor

Following on from #3877, I noticed that PyCFunction::new_closure_bound has a bound that still uses the GIL ref api for the closure. This updates that to use the Bound api instead.

LilyFoote
LilyFoote commented Feb 22, 2024
View reviewed changes
src/types/function.rs Outdated Show resolved Hide resolved
@LilyFoote LilyFoote added the CI-skip-changelog Skip checking changelog entry label Feb 22, 2024
Icxolu
Icxolu reviewed Feb 22, 2024
View reviewed changes
src/types/function.rs Outdated Show resolved Hide resolved
src/types/function.rs Outdated Show resolved Hide resolved
@LilyFoote LilyFoote force-pushed the pycfunction-new-closure branch 2 times, most recently from 6ab1624 to fd380b1 Compare February 22, 2024 21:33
@LilyFoote LilyFoote marked this pull request as ready for review February 22, 2024 21:33
Icxolu
Icxolu approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

davidhewitt
davidhewitt reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up! I have a suggestion, which is sort of for my own learning too 😂

src/types/function.rs Outdated Show resolved Hide resolved
src/types/function.rs Outdated Show resolved Hide resolved
davidhewitt
davidhewitt reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both! One final thought from me...

src/types/function.rs Outdated Show resolved Hide resolved
davidhewitt
davidhewitt approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both, this looks correct and elegantly implemented!

@davidhewitt davidhewitt added this pull request to the merge queue Feb 23, 2024
Merged via the queue into PyO3:main with commit e145ae8 Feb 23, 2024
39 of 40 checks passed
@LilyFoote LilyFoote deleted the pycfunction-new-closure branch February 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LilyFoote @davidhewitt @Icxolu